Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/194 PHP Deprecated Warning #203

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix/194 PHP Deprecated Warning #203

merged 2 commits into from
Jun 14, 2024

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Jun 14, 2024

Description of the Change

This PR handles the case where the image_meta is not an array and sets it to an empty array to avoid PHP warnings.

Closes #194

How to test the Change

As this is not a straightforward issue so it is difficult to write steps to regenerate the issue.

Changelog Entry

Fixed - Fixed - Handled PHP warning when the $image_meta is not an array.

Credits

Props @drazenbebic, @kirtangajjar, @faisal-alvi , @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi added this to the Future Release milestone Jun 14, 2024
@faisal-alvi faisal-alvi self-assigned this Jun 14, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jun 14, 2024
@faisal-alvi faisal-alvi mentioned this pull request Jun 14, 2024
1 task
@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Jun 14, 2024
safe-svg.php Outdated Show resolved Hide resolved
@faisal-alvi faisal-alvi requested review from dkotter and removed request for jeffpaul June 14, 2024 16:57
@faisal-alvi faisal-alvi merged commit 60749d7 into develop Jun 14, 2024
15 checks passed
@faisal-alvi faisal-alvi deleted the fix/194 branch June 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.3 Compatibility
3 participants