Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal-ize and fix all 18f.gsa.gov links #4136

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

beechnut
Copy link
Contributor

@beechnut beechnut commented Nov 7, 2024

Pull request summary

This PR makes 2 changes.

First, it makes all links to 18f.gsa.gov pages internal. This makes all the internal site links checkable by the link checker, which can only check internal links. This first change made a lot of links' brokenness visible for the first time.

Next, it corrects broken links. For what I think was the majority of links, they just needed a trailing slash, or to be redirected, or to remove anchors that no longer exist even when the pages still do. But for places where the links are extremely broken — like they reference a project or 18F initiative from long ago — I added "(link removed)" so it wouldn't be too confusing to future readers.

This commit changes all links that start with 18f.gsa.gov to internal link format. This makes all the 18f.gsa.gov links checkable by the internal link checker.

This commit causes a lot of links' brokenness to become visible for the first time.
This commit:

- Corrects broken links to real paths
- Adds redirects to pages as necessary, to handle old links gracefully
- Removes broken links, mostly to defunct 18F projects like /dashboard, /hub (which evolved into Handbook), etc.
- Marks removed links with "(link removed)" when it's clear there should have been a link there before
@beechnut beechnut requested a review from a team as a code owner November 7, 2024 19:04
@beechnut beechnut changed the title Fix all 18f.gsa.gov links Internal-ize and fix all 18f.gsa.gov links Nov 7, 2024
Copy link
Member

@adunkman adunkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving these & fixing the found broken links!

@beechnut beechnut merged commit 3eaaa14 into main Nov 25, 2024
8 checks passed
@beechnut beechnut deleted the beechnut/fix-internal-links branch November 25, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants