Omit errors from analytics when error_details available

app/forms/webauthn_visit_form.rb

@@ -41,10 +41,9 @@ def check_params(params)
     return unless error
 
     if @platform_authenticator
-      errors.add error, translate_platform_authenticator_error(error),
-                 type: :"#{translate_platform_authenticator_error(error).split('.').last}"
+      errors.add error, translate_platform_authenticator_error(error), type: :invalid
     else
-      errors.add error, translate_error(error), type: :"#{translate_error(error).split('.').last}"
+      errors.add error, translate_error(error), type: :invalid
     end
   end
 

app/services/form_response.rb

@@ -19,7 +19,7 @@ def success?
 
   def to_h
     hash = { success: success }
-    hash[:errors] = errors.presence if !serialize_error_details_only?
+    hash[:errors] = (!defined?(@error_details) && errors).presence if !serialize_error_details_only?
     hash[:error_details] = flatten_details(error_details) if error_details.present?
     hash.merge!(extra)
     hash

spec/controllers/account_reset/cancel_controller_spec.rb

@@ -32,7 +32,6 @@
       expect(@analytics).to have_logged_event(
         'Account Reset: cancel',
         success: false,
-        errors: { token: [t('errors.account_reset.cancel_token_invalid', app_name: APP_NAME)] },
         error_details: {
           token: { cancel_token_invalid: true },
         },
@@ -48,7 +47,6 @@
       expect(@analytics).to have_logged_event(
         'Account Reset: cancel',
         success: false,
-        errors: { token: [t('errors.account_reset.cancel_token_missing', app_name: APP_NAME)] },
         error_details: { token: { blank: true } },
         user_id: 'anonymous-uuid',
       )
@@ -92,7 +90,6 @@
         'Account Reset: cancel token validation',
         user_id: 'anonymous-uuid',
         success: false,
-        errors: { token: [t('errors.account_reset.cancel_token_invalid', app_name: APP_NAME)] },
         error_details: {
           token: { cancel_token_invalid: true },
         },

spec/controllers/account_reset/delete_account_controller_spec.rb

@@ -6,7 +6,6 @@
   let(:invalid_token_message) do
     t('errors.account_reset.granted_token_invalid', app_name: APP_NAME)
   end
-  let(:invalid_token_error) { { token: [invalid_token_message] } }
 
   before { stub_analytics }
   describe '#delete' do
@@ -45,7 +44,6 @@
         'Account Reset: delete',
         user_id: 'anonymous-uuid',
         success: false,
-        errors: invalid_token_error,
         error_details: { token: { granted_token_invalid: true } },
         mfa_method_counts: {},
         identity_verified: false,
@@ -63,7 +61,6 @@
         'Account Reset: delete',
         user_id: 'anonymous-uuid',
         success: false,
-        errors: { token: [t('errors.account_reset.granted_token_missing', app_name: APP_NAME)] },
         error_details: { token: { blank: true } },
         mfa_method_counts: {},
         identity_verified: false,
@@ -91,7 +88,6 @@
         'Account Reset: delete',
         user_id: user.uuid,
         success: false,
-        errors: { token: [t('errors.account_reset.granted_token_expired', app_name: APP_NAME)] },
         error_details: { token: { granted_token_expired: true } },
         mfa_method_counts: {},
         identity_verified: false,
@@ -179,7 +175,6 @@
         'Account Reset: granted token validation',
         user_id: 'anonymous-uuid',
         success: false,
-        errors: invalid_token_error,
         error_details: { token: { granted_token_invalid: true } },
       )
       expect(response).to redirect_to(root_url)
@@ -199,7 +194,6 @@
         'Account Reset: granted token validation',
         user_id: user.uuid,
         success: false,
-        errors: { token: [t('errors.account_reset.granted_token_expired', app_name: APP_NAME)] },
         error_details: { token: { granted_token_expired: true } },
       )
       expect(response).to redirect_to(root_url)

spec/controllers/concerns/two_factor_authenticatable_methods_spec.rb

@@ -184,7 +184,6 @@
         expect(@analytics).to have_logged_event(
           'Multi-Factor Authentication',
           success: false,
-          errors: { code: ['pattern_mismatch'] },
           error_details: { code: { pattern_mismatch: true } },
           multi_factor_auth_method: TwoFactorAuthenticatable::AuthMethod::SMS,
           enabled_mfa_methods_count: 1,

spec/controllers/event_disavowal_controller_spec.rb

@@ -48,7 +48,6 @@
           build_analytics_hash(
             user_id: event.user.uuid,
             success: false,
-            errors: { event: [t('event_disavowals.errors.event_already_disavowed')] },
             error_details: { event: { event_already_disavowed: true } },
           ),
         )
@@ -64,7 +63,6 @@
           build_analytics_hash(
             user_id: event.user.uuid,
             success: false,
-            errors: { event: [t('event_disavowals.errors.event_already_disavowed')] },
             error_details: { event: { event_already_disavowed: true } },
           ),
         )
@@ -102,13 +100,6 @@
           build_analytics_hash(
             user_id: event.user.uuid,
             success: false,
-            errors: {
-              password: [
-                t(
-                  'errors.attributes.password.too_short.other', count: Devise.password_length.first
-                ),
-              ],
-            },
             error_details: { password: { too_short: true } },
           ),
         )
@@ -127,7 +118,6 @@
           build_analytics_hash(
             user_id: event.user.uuid,
             success: false,
-            errors: { password: ['Password must be at least 12 characters long'] },
             error_details: { password: { too_short: true } },
           ),
         )
@@ -151,7 +141,6 @@
           build_analytics_hash(
             user_id: event.user.uuid,
             success: false,
-            errors: { event: [t('event_disavowals.errors.event_already_disavowed')] },
             error_details: { event: { event_already_disavowed: true } },
           ),
         )
@@ -173,9 +162,6 @@
           'Event disavowal token invalid',
           build_analytics_hash(
             success: false,
-            errors: {
-              user: [t('event_disavowals.errors.no_account')],
-            },
             error_details: {
               user: { blank: true },
             },
@@ -185,12 +171,11 @@
     end
   end
 
-  def build_analytics_hash(success: true, errors: nil, error_details: nil, user_id: nil)
+  def build_analytics_hash(success: true, error_details: nil, user_id: nil)
     {
       event_created_at: event.created_at,
       disavowed_device_last_used_at: event.device&.last_used_at,
       success:,
-      errors:,
       error_details:,
       event_id: event.id,
       event_type: event.event_type,

spec/controllers/idv/by_mail/enter_code_controller_spec.rb

@@ -163,7 +163,6 @@
   end
 
   describe '#create' do
-    let(:otp_code_error_message) { { otp: [t('errors.messages.confirmation_code_incorrect')] } }
     let(:success_properties) { { success: true } }
 
     context 'user does not have a pending profile' do
@@ -382,7 +381,6 @@
         expect(@analytics).to have_logged_event(
           'IdV: enter verify by mail code submitted',
           success: false,
-          errors: otp_code_error_message,
           pending_in_person_enrollment: false,
           fraud_check_failed: false,
           letter_count: 1,
@@ -416,7 +414,6 @@
         it 'redirects to the rate limited index page to show errors' do
           analytics_args = {
             success: false,
-            errors: otp_code_error_message,
             pending_in_person_enrollment: false,
             fraud_check_failed: false,
             letter_count: 1,
@@ -450,11 +447,11 @@
 
           failed_gpo_submission_events =
             @analytics.events['IdV: enter verify by mail code submitted']
-              .reject { |event_attributes| event_attributes[:errors].blank? }
+              .reject { |event_attributes| event_attributes[:error_details].blank? }
 
           successful_gpo_submission_events =
             @analytics.events['IdV: enter verify by mail code submitted']
-              .select { |event_attributes| event_attributes[:errors].blank? }
+              .select { |event_attributes| event_attributes[:error_details].blank? }
 
           expect(failed_gpo_submission_events.count).to eq(max_attempts - 1)
           expect(successful_gpo_submission_events.count).to eq(1)

spec/controllers/idv/how_to_verify_controller_spec.rb

@@ -171,7 +171,6 @@
           step: 'how_to_verify',
           analytics_id: 'Doc Auth',
           error_details: { selection: { blank: true } },
-          errors: { selection: ['Select a way to verify your identity.'] },
           success: false,
         }
       end
@@ -191,7 +190,6 @@
           analytics_id: 'Doc Auth',
           selection:,
           error_details: { selection: { inclusion: true } },
-          errors: { selection: ['Select a way to verify your identity.'] },
           success: false,
         }
       end

spec/controllers/idv/image_uploads_controller_spec.rb

@@ -103,9 +103,6 @@
         expect(@analytics).to have_logged_event(
           'IdV: doc auth image upload form submitted',
           success: false,
-          errors: {
-            front: [I18n.t('doc_auth.errors.not_a_file')],
-          },
           error_details: {
             front: { not_a_file: true },
           },
@@ -219,9 +216,6 @@
         expect(@analytics).to have_logged_event(
           'IdV: doc auth image upload form submitted',
           success: false,
-          errors: {
-            limit: [I18n.t('doc_auth.errors.rate_limited_heading')],
-          },
           error_details: {
             limit: { rate_limited: true },
           },
@@ -520,9 +514,6 @@
             expect(@analytics).to have_logged_event(
               'IdV: doc auth image upload vendor pii validation',
               success: false,
-              errors: {
-                name: [I18n.t('doc_auth.errors.alerts.full_name_check')],
-              },
               error_details: {
                 name: { name: true },
               },
@@ -598,9 +589,6 @@
             expect(@analytics).to have_logged_event(
               'IdV: doc auth image upload vendor pii validation',
               success: false,
-              errors: {
-                state: [I18n.t('doc_auth.errors.general.no_liveness')],
-              },
               error_details: {
                 state: { inclusion: true },
               },
@@ -676,9 +664,6 @@
             expect(@analytics).to have_logged_event(
               'IdV: doc auth image upload vendor pii validation',
               success: false,
-              errors: {
-                state_id_number: [I18n.t('doc_auth.errors.general.no_liveness')],
-              },
               error_details: {
                 state_id_number: { blank: true },
               },
@@ -750,9 +735,6 @@
             expect(@analytics).to have_logged_event(
               'IdV: doc auth image upload vendor pii validation',
               success: false,
-              errors: {
-                dob: [I18n.t('doc_auth.errors.alerts.birth_date_checks')],
-              },
               error_details: {
                 dob: { dob: true },
               },
@@ -825,11 +807,6 @@
             expect(@analytics).to have_logged_event(
               'IdV: doc auth image upload vendor pii validation',
               success: false,
-              errors: {
-                state_id_expiration: [
-                  'Try taking new pictures.',
-                ],
-              },
               error_details: {
                 state_id_expiration: { state_id_expiration: true },
               },

spec/controllers/idv/in_person/ssn_controller_spec.rb

@@ -197,9 +197,6 @@
           flow_path: 'standard',
           step: 'ssn',
           success: false,
-          errors: {
-            ssn: ['Enter a nine-digit Social Security number'],
-          },
           error_details: { ssn: { invalid: true } },
         }
       end

spec/controllers/idv/phone_controller_spec.rb

@@ -290,10 +290,6 @@
         expect(@analytics).to have_logged_event(
           'IdV: phone confirmation form',
           success: false,
-          errors: {
-            phone: [improbable_phone_message],
-            otp_delivery_preference: [improbable_otp_message],
-          },
           error_details: {
             phone: { improbable_phone: true },
             otp_delivery_preference: { inclusion: true },

spec/controllers/idv/ssn_controller_spec.rb

@@ -234,9 +234,6 @@
           flow_path: 'standard',
           step: 'ssn',
           success: false,
-          errors: {
-            ssn: [t('idv.errors.pattern_mismatch.ssn')],
-          },
           error_details: { ssn: { invalid: true } },
         }
       end

spec/controllers/openid_connect/authorization_controller_spec.rb

@@ -2009,7 +2009,6 @@
             prompt: '',
             allow_prompt_login: true,
             unauthorized_scope: true,
-            errors: hash_including(:prompt),
             error_details: hash_including(:prompt),
             user_fully_authenticated: true,
             acr_values: acr_values,
@@ -2071,7 +2070,6 @@
               prompt:,
               allow_prompt_login: true,
               unauthorized_scope: false,
-              errors: hash_including(:acr_values),
               error_details: hash_including(:acr_values),
               user_fully_authenticated: true,
               acr_values: '',
@@ -2237,7 +2235,6 @@
             prompt: '',
             allow_prompt_login: true,
             unauthorized_scope: true,
-            errors: hash_including(:prompt),
             error_details: hash_including(:prompt),
             user_fully_authenticated: true,
             acr_values: '',
@@ -2276,7 +2273,6 @@
             success: false,
             prompt: 'select_account',
             unauthorized_scope: true,
-            errors: hash_including(:client_id),
             error_details: hash_including(:client_id),
             user_fully_authenticated: true,
             acr_values: 'http://idmanagement.gov/ns/assurance/ial/1',
@@ -2311,7 +2307,6 @@
             success: false,
             prompt: 'select_account',
             unauthorized_scope: true,
-            errors: hash_including(:client_id),
             error_details: hash_including(:client_id),
             user_fully_authenticated: true,
             acr_values: '',