-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-15294: Integrate Flow Policy with IPP steps - State ID and Address #11815
base: main
Are you sure you want to change the base?
Conversation
changelog: Internal, In-person proofing, integrates the flow policy into the state id and address controllers
@@ -60,7 +60,7 @@ def self.step_info | |||
Idv::StepInfo.new( | |||
key: :document_capture, | |||
controller: self, | |||
next_steps: [:ssn, :ipp_ssn], # :ipp_state_id | |||
next_steps: [:ssn, :ipp_state_id], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered if this changes was needed for other flows (hybrid and socure). Jenny and I paired on this- looks like it is not needed for hybrid but needed for socure because you can go back from socure like you can with doc auth. You cannot in hybrid so no need to clean up state id data if you can't go back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We thought through this some more and determined that in order to go back from IPP to socure, like hybrid, a user would have to start all the way over, so it's not necessary to clear ipp_state_id from here. Leaving it only in this document_capture_controller.
…ta is being properly cleared via flowpolicy
395e2cc
to
43e41ef
Compare
🎫 Ticket
Link to the relevant ticket:
LG-15294
🛠 Summary of changes
During FSM clean-up we discovered that the flow policy was not yet being fully used within the in_person/state_id_controller and in_person/address_controller. The step_info was included but it wasn't yet being called. These changes address that by adding the confirm_step_allowed before_action and refactoring the undo_step lambdas in both the state_id_controller and address_controller, so they could be properly called in the clear_future_steps! Flow Policy step.
📜 Testing Plan
There is no new or changed functionality for manual testing - you will want to test the IPP flow to make sure everything is working as usual.