Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15294: Integrate Flow Policy with IPP steps - State ID and Address #11815

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jennyverdeyen
Copy link
Member

🎫 Ticket

Link to the relevant ticket:
LG-15294

🛠 Summary of changes

During FSM clean-up we discovered that the flow policy was not yet being fully used within the in_person/state_id_controller and in_person/address_controller. The step_info was included but it wasn't yet being called. These changes address that by adding the confirm_step_allowed before_action and refactoring the undo_step lambdas in both the state_id_controller and address_controller, so they could be properly called in the clear_future_steps! Flow Policy step.

📜 Testing Plan

There is no new or changed functionality for manual testing - you will want to test the IPP flow to make sure everything is working as usual.

  • Enter through sinatra, choosing identity-verified for level of service
  • Begin through the in-person flow, stopping at document_capture
  • Try to change the url to /verify/in_person/state_id - there is no establishing enrollment yet so the precondition should fail and you should be redirected to document_capture.
  • Continue through /document_capture and arrive at /in_person/state_id. Do not submit state id yet.
  • Try to change the url to /verify/in_person/address. Because the state id step is not completed yet, the precondition should fail and you should be redirected to state_id.
  • Continue through the in-person flow and successfully create an enrollment.

@jennyverdeyen jennyverdeyen requested review from a team and KeithNava January 28, 2025 17:23
@@ -60,7 +60,7 @@ def self.step_info
Idv::StepInfo.new(
key: :document_capture,
controller: self,
next_steps: [:ssn, :ipp_ssn], # :ipp_state_id
next_steps: [:ssn, :ipp_state_id],
Copy link
Contributor

@gina-yamada gina-yamada Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if this changes was needed for other flows (hybrid and socure). Jenny and I paired on this- looks like it is not needed for hybrid but needed for socure because you can go back from socure like you can with doc auth. You cannot in hybrid so no need to clean up state id data if you can't go back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We thought through this some more and determined that in order to go back from IPP to socure, like hybrid, a user would have to start all the way over, so it's not necessary to clear ipp_state_id from here. Leaving it only in this document_capture_controller.

@jennyverdeyen jennyverdeyen force-pushed the jverdeyen/LG-15294-integrate-flow-policy-ipp branch from 395e2cc to 43e41ef Compare January 30, 2025 20:31
@jennyverdeyen jennyverdeyen removed the request for review from KeithNava January 30, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants