Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15479: Fix nil zipcode error during identity resolution #11820

Merged
merged 1 commit into from
Feb 6, 2025
Merged

LG-15479: Fix nil zipcode error during identity resolution #11820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/controllers/idv/link_sent_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ def update
analytics.idv_doc_auth_link_sent_submitted(**analytics_arguments)

return render_document_capture_cancelled if document_capture_session&.cancelled_at

# If the user opted into in-person proofing in the hybrid session,
Copy link
Contributor

@gina-yamada gina-yamada Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - We usually say "opt in" when the user picked In Person on the How to Verify view. When they fail and then move to opt in- we don't refer to that as opt in bc it was not their first pick

Maybe... If the user failed remote and then moved to in-person proofing in the...

Not a deal breaker if you don't change it

# we should be able to find an establishing IPP enrollment
if current_user.has_establishing_in_person_enrollment?
redirect_to idv_in_person_url
return
end

# Otherwise, we assume the user is still in the remote doc auth flow.

return render_step_incomplete_error unless take_photo_with_phone_successful?

# The doc capture flow will have fetched the results already. We need
Expand Down
34 changes: 34 additions & 0 deletions spec/features/idv/in_person_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,40 @@
perform_mobile_hybrid_steps
perform_desktop_hybrid_steps(user, same_address_as_id: false)
end

context 'when polling times out and the user has to click the "Continue" button' do
before do
# When polling times out on the client, the "Continue" button is displayed to the user
# We can simulate that by just completely disabling polling.
allow(FeatureManagement).to receive(:doc_capture_polling_enabled?).and_return(false)
end

it 'redirects the user to the in-person proofing path',
allow_browser_log: true do
user = nil
perform_in_browser(:desktop) do
user = sign_in_and_2fa_user
complete_doc_auth_steps_before_hybrid_handoff_step
clear_and_fill_in(:doc_auth_phone, '415-555-0199')
click_send_link

expect(page).to have_content(t('doc_auth.headings.text_message'))
end

expect(@sms_link).to be_present

perform_mobile_hybrid_steps

perform_in_browser(:desktop) do
expect(page).to have_current_path(idv_link_sent_path)

# Click the "Continue" button on the link sent page since we're not polling
click_idv_continue
end

perform_desktop_hybrid_steps(user)
end
end
end

context 'verify by mail not allowed for in-person' do
Expand Down