FEAT: Support imagePullSecrets in connect chart #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're also interested in this as we would like to pull the image through our registry proxy to not hit dockerhub rate limiting. Another option to set the imagePullSecrets would be attaching them to a specific serviceaccount but this is also not configurable for connect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The helm chart support changing the container registry. However, it does not support
imagePullSecretswhich means that the images on our private registry must be public.Proposal
Add this
imagePullSecretson the connect and operator deployment. By default, there is nothing but we can add this value if we want to use private registry.