Added configurable securityContext and follow restricted PSS
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything I'm missing or that I can help with to get this PR reviewed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! We want to be able to control the
securityContextof the 1Password Connect pods to follow our own set of guidelines. Such as we want our pods to use a specific UID.I've also changed it to follow the
restrictedPod Security Standard by default, so people can use the 1Password Connect operator when they have thepod-security.kubernetes.io/enforce: restrictednamespace label.Changes:
securityContextsettings to connect chartsecurityContextsettings to secrets-injector chartsecurityContextto followrestrictedPod Security Standard by defaultpre-upgradeto secrets-injector to also update on upgradesemptyDirfor/tmpto secrets-injector as I'm settingsecurityContext.readOnlyRootFilesystem: trueand the glog library requires it to write logs into (changing-alsologtostderrto-logtostderrdidn't help)I've tested this by installing into a test cluster and running the acceptance tests.
Closes #192