Change make_credential::Response order to follow CTAP2.1 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progdrasil
force-pushed
the
progdrasil/fix-ctap2-make-credential-response-order
branch
from
83baaf4 to
33a7501
Compare
Vogeltak
approved these changes
Aug 1, 2024
Progdrasil
deleted the
progdrasil/fix-ctap2-make-credential-response-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were following CTAP2.0 at the time of authoring passkey-types while this order was changed in CTAP2.1. This was changed due do a mismatch between security keys and the spec. The spec changed to follow what security keys were doing.