-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
11,673 additions
and
11,837 deletions.
There are no files selected for viewing
2,156 changes: 1,078 additions & 1,078 deletions
2,156
qodana/results/descriptions/Code_Inspection.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,57 +1 @@ | ||
{"version":"3","listProblem":[{ | ||
"tool": "Code Inspection", | ||
"category": "Code maturity", | ||
"type": "Commented out code", | ||
"severity": "Moderate", | ||
"comment": "Commented out code (6 lines)", | ||
"detailsInfo": "Reports comments that contain Java code.\n\nUsually, code that is commented out gets outdated very quickly and becomes misleading.\nAs most projects use some kind of version control system,\nit is better to delete commented out code completely and use the VCS history instead.\n\nNew in 2020.3", | ||
"sources": [ | ||
{ | ||
"type": "file", | ||
"path": "src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java", | ||
"language": "JAVA", | ||
"line": 72, | ||
"offset": 1, | ||
"length": 2, | ||
"code": { | ||
"startLine": 70, | ||
"length": 2, | ||
"offset": 36, | ||
"surroundingCode": " var range = params.getRange();\n\n// var ast = documentContext.getAst();\n// Trees.findAllRuleNodes(\n// ast," | ||
} | ||
} | ||
], | ||
"attributes": { | ||
"module": "bsl-language-server.main", | ||
"inspectionName": "CommentedOutCode" | ||
}, | ||
"hash": "5f0674d74495771954e4a3d3cbe6882a73d6c81eae51abc3ad43b4d2c3b0eb28" | ||
},{ | ||
"tool": "Code Inspection", | ||
"category": "Verbose or redundant code constructs", | ||
"type": "Unnecessary 'continue' statement", | ||
"severity": "High", | ||
"comment": "`continue` is unnecessary as the last statement in a loop", | ||
"detailsInfo": "Reports `continue` statements if they are the last reachable statements in the loop. These `continue` statements are unnecessary and can be safely removed.\n\nExample:\n\n\n for (String element: elements) {\n System.out.println();\n continue;\n }\n\nAfter the quick-fix is applied:\n\n\n for (String element: elements) {\n System.out.println();\n }\n\nThe inspection doesn't analyze JSP files.\n\n\nUse the **Ignore in then branch of 'if' statement with 'else' branch** option to ignore\n`continue` statements when they are placed in a `then` branch of a complete\n`if`-`else` statement.\n\nExample:\n\n\n for (String element: elements) {\n if(element.isEmpty()) {\n continue;\n } else {\n //...\n }\n }\n", | ||
"sources": [ | ||
{ | ||
"type": "file", | ||
"path": "src/main/java/com/github/_1c_syntax/bsl/languageserver/utils/expressiontree/ExpressionTreeBuildingVisitor.java", | ||
"language": "JAVA", | ||
"line": 99, | ||
"offset": 11, | ||
"length": 8, | ||
"code": { | ||
"startLine": 97, | ||
"length": 8, | ||
"offset": 144, | ||
"surroundingCode": " visitMember((BSLParser.MemberContext) child);\n } else if (child.getClass() == BSLParser.PreprocessorContext.class) {\n continue;\n } else {\n throw new IllegalStateException();" | ||
} | ||
} | ||
], | ||
"attributes": { | ||
"module": "bsl-language-server.main", | ||
"inspectionName": "UnnecessaryContinue" | ||
}, | ||
"hash": "8cc81c86fb327f144191359d8026afa00236f66f632e452051aa19d63a0540d0" | ||
}]} | ||
{"version":"3","listProblem":[]} |
Oops, something went wrong.