Правило "Запуск внешних приложений" - ExternalAppStarting #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nixel2007 @theshadowco @otymko Правило готово, проверяйте. |
|
Kudos, SonarCloud Quality Gate passed! |
artbear
changed the title
theshadowco
reviewed
Sep 11, 2023
...java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic.java
Show resolved
Hide resolved
...github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_en.properties
Outdated
Show resolved
Hide resolved
...github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_ru.properties
Outdated
Show resolved
Hide resolved
.../com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnosticTest.java
Show resolved
Hide resolved
artbear
changed the title
переделаны тесты выполнен precommit
WalkthroughThe recent updates introduce a diagnostic feature to identify and manage security risks associated with the execution of external applications from 1C code. This enhancement aims to extend security measures, covering various methods of launching external programs and providing a mechanism to avoid false positives, with a focus on maintaining the security and integrity of the codebase. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/configuration/parameters-schema.json
Files selected for processing (7)
- docs/diagnostics/ExternalAppStarting.md (1 hunks)
- docs/en/diagnostics/ExternalAppStarting.md (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic.java (1 hunks)
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_en.properties (1 hunks)
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_ru.properties (1 hunks)
- src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnosticTest.java (1 hunks)
- src/test/resources/diagnostics/ExternalAppStartingDiagnostic.bsl (1 hunks)
Files skipped from review due to trivial changes (2)
- docs/en/diagnostics/ExternalAppStarting.md
- src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_ru.properties
Additional comments: 5
src/main/resources/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic_en.properties (1)
- 1-4: The English localization for the diagnostic messages is correctly formatted and consistent with the diagnostic's purpose.
src/test/resources/diagnostics/ExternalAppStartingDiagnostic.bsl (1)
- 2-58: The BSL script file contains comprehensive test cases for the diagnostic, covering a variety of methods that should be flagged.
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnostic.java (1)
- 35-79: The Java class implementing the diagnostic correctly declares parameters and the configure method appends the pattern for navigation links based on the checkGotoUrl parameter.
docs/diagnostics/ExternalAppStarting.md (1)
- 1-78: The Markdown documentation for the diagnostic is clear and provides useful examples and sources.
src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ExternalAppStartingDiagnosticTest.java (1)
- 37-131: The Java test class for the diagnostic includes tests that cover its behavior with different configurations.
theshadowco
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Реализовано новое правило "Запуск внешних приложений" - ExternalAppStarting
для исключения ФП нужно добавить флаг для срабатывания на ПерейтиПоНавигационнойСсылке или ФайловаяСистемаКлиент.ОткрытьНавигационнуюСсылку
Скорее всего, нужен еще параметр правила для глобальных методов и методов объектов
чтобы добавлять новые методы, например, из типовых конфигураций или БСП
Добавить ЗапуститьСистему
Отдельная проверка на COM-объекты не нужна
например, на все (лучше) или только "Wscript.Shell" и "Shell.Application" (хуже)
Связанные задачи
Closes #3114
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно
Summary by CodeRabbit
New Features
Documentation
Localization
Tests