Исправлен выброс исключения диагностики DoubleNegatives при наборе кода/ошибках разбора #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Rate limit exceeded@nixel2007 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughВ этом пулл-реквесте обновлена обработка ошибок в классе ExpressionTreeBuildingVisitor. В методе visitExpression вместо утверждения теперь используется условная проверка: при отсутствии операции происходит уменьшение уровня рекурсии с возвратом контекста. В методе visitMember добавлена проверка на наличие дочерних элементов, что позволяет избежать ошибок при отсутствии детей. Дополнительно, в тестовом файле добавлена процедура Тест(), содержащая ошибочные конструкции (Если, Пока) для проверки устойчивости парсера. Changes
Sequence Diagram(s)sequenceDiagram
participant C as Клиент
participant ET as ExpressionTreeBuildingVisitor
C->>ET: visitExpression(ctx)
alt Операция отсутствует
ET->>ET: Уменьшение recursionLevel
ET-->>C: Возврат ctx (обработка ошибки)
else Операция присутствует
ET->>ET: Обработка дерева выражения
ET-->>C: Возврат результата
end
sequenceDiagram
participant C as Клиент
participant ET as ExpressionTreeBuildingVisitor
C->>ET: visitMember(ctx)
alt Отсутствуют дочерние элементы
ET-->>C: Немедленный возврат ctx
else Дочерние элементы присутствуют
ET->>ET: Обработка дочерних элементов
ET-->>C: Возврат результата
end
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
nixel2007
force-pushed
the
fix/double-negatives
branch
from
165184b to
59a7d9c
Compare
nixel2007
changed the title
…да/ошибках разбора кода
nixel2007
force-pushed
the
fix/double-negatives
branch
from
59a7d9c to
14eabe5
Compare
Qodana for JVM78 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 102 dependenciesThird-party software listThis page lists the third-party software dependencies used in bsl-language-server
Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…да/ошибках разбора кода
Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно