Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell biome to read from the version specified in the root directory #614

Merged
merged 11 commits into from
May 2, 2024
5 changes: 0 additions & 5 deletions .github/workflows/integrate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ jobs:

- name: Setup Biome
uses: biomejs/setup-biome@v2
with:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key was deleting this bit in combination with making sure biome was installed at a pinned version, without a caret (^)

# This allows the setup action to resolve the biome version to install
# from the package.json file in the project's directory. Falls back to
# the latest stable version if no version is specified.
working-dir: ${{ matrix.project }}

- name: Run Biome
# This runs the biome command in the project's directory.
Expand Down
5 changes: 0 additions & 5 deletions apps/site/biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,5 @@
"noSvgWithoutTitle": "off"
}
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe this bit is just unnecessary here.

"vcs": {
"enabled": true,
"clientKind": "git",
"useIgnoreFile": true
}
}
9 changes: 6 additions & 3 deletions apps/site/components/client/MenuDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function MenuDialog() {
</DialogClose>
</DialogHeader>
<Stack className="h-full w-full pt-[52px] items-start gap-y-6">
<DialogClose asChild>
<DialogClose asChild>
<Button
variant="link"
className="w-full h-5 justify-start rounded-none"
Expand All @@ -66,7 +66,7 @@ export function MenuDialog() {
</Flex>
</Link>
</Button>
</DialogClose>
</DialogClose>
<DialogClose asChild>
<Button
variant="link"
Expand Down Expand Up @@ -108,7 +108,10 @@ export function MenuDialog() {
</DialogClose>
{!authenticated ? (
<>
<Separator orientation="vertical" className="h-4 border-none bg-0" />
<Separator
orientation="vertical"
className="h-4 border-none bg-0"
/>
<DialogClose asChild>
<Button
variant="link"
Expand Down
10 changes: 5 additions & 5 deletions apps/site/context/UserContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import React, {
} from 'react'
import { getUserDataByOwner } from '@/lib'
import { getUserId } from '@/gql'
import { Address } from 'viem'
import type { Address } from 'viem'

const UserContext = createContext<{
embeddedWallet?: ConnectedWallet
Expand Down Expand Up @@ -54,17 +54,17 @@ export function UserContextComponent({ children }: { children: ReactNode }) {
if (data) {
// if succcessful from username db, set user id, name, and channels for user
setUserId(BigInt(data.records.id))
setUsername(data.records.name)
setUsername(data.records.name)
const userChannels = await getUserChannels(data.records.id)
if (userChannels) setUserChannels(userChannels)
if (userChannels) setUserChannels(userChannels)
} else {
// if not successful from username db, fetch from ponder. means that user may have id
// but not username yet
userIdFromDelta = await getUserId({
custodyAddress: embeddedWallet.address as Address,
})
})
if (!userIdFromDelta.userId) return
setUserId(userIdFromDelta.userId)
setUserId(userIdFromDelta.userId)
}
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dev:site": "pnpm dev --filter=site"
},
"devDependencies": {
"@biomejs/biome": "^1.6.4",
"@biomejs/biome": "1.6.4",
"turbo": "^1.10.16"
},
"packageManager": "[email protected]"
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.