Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private owners #10

Open
wants to merge 4 commits into
base: private_owners
Choose a base branch
from

Conversation

khemiriwalid
Copy link

No description provided.

@valeryz-1kx valeryz-1kx changed the base branch from main to private_owners December 16, 2024 14:49
Copy link
Contributor

@valeryz valeryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however why does the circuit now support only 4 signers?

}
}
assert(num_verified_signatures >= threshold);
}

fn main(threshold: pub u8, signers: [PubKey; 10], signatures: [Signature; 10], txn_hash: pub Hash, owners: pub [Address; 10]) {
verify_signers(threshold, signers, signatures, txn_hash, owners);
fn main(threshold: pub u8, signers: [PubKey; 4], signatures: [Signature; 4], txn_hash: pub Hash, owners_root: pub Field, indices: [Field; 4], siblings: [[Field; TREE_SIZE]; 4]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have only 4 signers down from 10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants