Trim URLs before parsing

21TORR · Mar 4, 2024 · dae0688 · dae0688
1 parent 08b7201
commit dae0688
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+1.0.3
+=====
+
+* (improvement) Trim URLs before parsing.
+
+
 1.0.2
 =====
 

diff --git a/src/Video/VideoUrlParser.php b/src/Video/VideoUrlParser.php
@@ -26,6 +26,8 @@ public function __construct (
 	 */
 	public function parseVideoUrl (string $url) : ?VideoDetails
 	{
+		$url = \trim($url);
+
 		foreach ($this->parsers as $parser)
 		{
 			$details = $parser->parseUrl($url);

diff --git a/tests/Video/VideoUrlParsingTest.php b/tests/Video/VideoUrlParsingTest.php
@@ -25,6 +25,7 @@ public static function provideTestCases () : iterable
 		yield "youtu.be https" => ["https://youtu.be/1234567890_", VideoPlatform::YouTube, "1234567890_"];
 		yield "youtu.be http" => ["http://youtu.be/1234567890_", VideoPlatform::YouTube, "1234567890_"];
 		yield "youtube/oembed" => ["https://www.youtube.com/oembed?url=http%3A//www.youtube.com/watch?v%3D1234567890_&format=json", VideoPlatform::YouTube, "1234567890_"];
+		yield "youtube http with space" => ["https://www.youtube.com/watch?v=1234567890_ ", VideoPlatform::YouTube, "1234567890_"];
 
 		// YouTube: invalid
 		yield "youtube/watch invalid id" => ["http://www.youtube.com/watch?v=123456789012", null];
-Original file line number
+Diff line change
@@ -1,3 +1,9 @@
+.0.3
+    =====
+    * (improvement) Trim URLs before parsing.
 .0.2
     =====
@@ Expand Down @@