Add common Webpack Build Config for NextJS projects and Storybook for a shared SVGR integration. #37
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |
| *.d.ts | ||
| *.js | ||
| !/@types/*.d.ts | ||
| !/src/build-config/*.js | ||
|
|
||
| # don't ignore test files | ||
| !/tests/**/*.js | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| export const registerSvgWebpackLoader = (config) => | ||
| { | ||
| // Grab the existing rule that handles SVG imports | ||
| const fileLoaderRule = config.module.rules.find((rule) => rule.test?.test?.(".svg") && rule.resourceQuery?.toString() !== "/raw/"); | ||
|
There was a problem hiding this comment. I don't remember the deal about the |
||
| // Modify the file loader rule to ignore *.svg, since we have it handled now. | ||
| fileLoaderRule.exclude = /\.svg$/i; | ||
|
There was a problem hiding this comment. We should
|
||
|
|
||
| // Convert all other *.svg imports to React components | ||
| config.module.rules.push({ | ||
| test: /\.svg$/i, | ||
| issuer: { not: /\.(css|scss|sass)$/ }, | ||
| resourceQuery: { not: /url/ }, // exclude if *.svg?url | ||
| use: [{ | ||
| loader: "@svgr/webpack", | ||
| options: { | ||
| dimensions: true, | ||
| svgo: true, | ||
| svgoConfig: { | ||
| plugins: [ | ||
| { | ||
| name: "preset-default", | ||
| params: { | ||
| overrides: { | ||
| // ensure unique IDs when embedding multiple times | ||
| cleanupIds: false, | ||
| // don't remove the viewbox, to avoid scaling issues | ||
| removeViewBox: false, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: "removeAttrs", | ||
| params: { | ||
| attrs: "data-.*", | ||
| }, | ||
| }, | ||
| { | ||
| // ensure unique IDs when embedding multiple times | ||
| name: "prefixIds", | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| }], | ||
| }); | ||
|
|
||
| return config; | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should write it as TS now, so we don't need any new infrastructure.
Type-wise that might get hard, but using simplified types here is fine.