Add onMenuButton event to RNSScreenView #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement recogniser to trigger mentioned event.
|
I hate the code styling (and some patterns), but tried to match the existing code 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement recogniser to trigger mentioned event.
Description
Implements a recogniser on RNSScreenView for the tvOS remote that watches for the menu button being pressed.
When this happens, a JS event named onMenuButton is triggered.
NOTE
This branch / PR is based on the 3.13.1 tag, since that was the version that was used in the example application we used for investigation and development.
Before merging (automatic merge should not be possible) the changes should be based (and modified to match) from the version that'll be used.
It seems Fabric support was added in later versions and some substantial changes were introduced. This should not affect the functionality, but a manual merge will be needed first.