chore(deps): bump react-dom and @types/react-dom #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
✅ Deploy Preview for 2anki-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/multi-a8028ed54a
branch
2 times, most recently
from
f13113b
to
419faaa
Compare
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 17.0.2 to 18.3.1 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v18.3.1/packages/react-dom) Updates `@types/react-dom` from 17.0.20 to 18.3.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/multi-a8028ed54a
branch
from
419faaa
to
1ca7f93
Compare
This gets the CI passing and resolves the following error:
TypeError: reactAct is not a function
4 |
5 | test('renders 2anki.net about', () => {
> 6 | render(<App />);
| ^
7 | const linkElement = screen.getByText(/What is 2anki/i);
8 | expect(linkElement).toBeInTheDocument();
9 | });
t# Please enter the commit message for your changes. Lines starting
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
- make PageLayout readonly - This assertion is unnecessary since it does not change the type of the expression.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 17.0.2 to 18.3.1Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
d6c42f7Bump to 18.3.18a015b6Add deprecation warning for unmountComponentAtNodec3b2839Add deprecation warning for findDOMNoded4ea75dReactDOMTestUtils deprecation warnings7548c01DeprecaterenderToStaticNodeStream(#28872) (#28874)5894232Enable warning for defaultProps on function components for everyone (#25699)c2a246eTurn on string ref deprecation warning for everybody (not codemoddable) (#25383)2cfb474Bump version from 18.2 to 18.3b345523[Fizz] Support abort reasons (#24680)bcbeb52[Fizz] Disallow complex children in <title> elements (#24679)Maintainer changes
This version was pushed to npm by react-bot, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 17.0.20 to 18.3.1Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @aalemayhu.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)