Don't write to ~/.docker/config.json unnecessarily

Also pass indent=4 to pretty print ~/.docker/config.json
2i2c-org · May 18, 2021 · 8743512 · 8743512
1 parent 807ee92
commit 8743512
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/deployer/hub.py b/deployer/hub.py
@@ -70,10 +70,11 @@ def ensure_docker_credhelpers(self):
                 config = {}
 
             helpers = config.get('credHelpers', {})
-            helpers[registry] = helper
-            config['credHelpers'] = helpers
-            with open(dockercfg_path, 'w') as f:
-                json.dump(config, f)
+            if helpers.get(registry) != helper:
+                helpers[registry] = helper
+                config['credHelpers'] = helpers
+                with open(dockercfg_path, 'w') as f:
+                    json.dump(config, f, indent=4)
 
 
     def auth_kubeconfig(self):