Merge pull request #3373 from consideRatio/pr/optional-gcp-node_version

terraform, gcp: enable specification of individual node pools version
2i2c-org · Nov 6, 2023 · a236bc6 · a236bc6
2 parents 881921c + ca7a62e
commit a236bc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/terraform/gcp/cluster.tf b/terraform/gcp/cluster.tf
@@ -247,7 +247,7 @@ resource "google_container_node_pool" "notebook" {
   cluster  = google_container_cluster.cluster.name
   project  = google_container_cluster.cluster.project
   location = google_container_cluster.cluster.location
-  version  = var.k8s_versions.notebook_nodes_version
+  version  = try(each.value.node_version, var.k8s_versions.notebook_nodes_version)
 
   # terraform treats null same as unset, so we only set the node_locations
   # here if it is explicitly overriden. If not, it will just inherit whatever

diff --git a/terraform/gcp/variables.tf b/terraform/gcp/variables.tf
@@ -98,7 +98,8 @@ variable "notebook_nodes" {
       {}
     ),
     resource_labels : optional(map(string), {}),
-    zones : optional(list(string), [])
+    zones : optional(list(string), []),
+    node_version : optional(string, ""),
   }))
   description = "Notebook node pools to create"
   default     = {}