Neurohackademy hub #1507
Merged
Neurohackademy hub #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
This still needs more work to happen in order to be called ready for the event #1505 (comment). But I believe that could happen in sub-sequent PRs, so I'll mark this PR as ready to review |
for more information, see https://pre-commit.ci
GeorgianaElena
force-pushed
the
neurohackademy-hub
branch
from
5a8d620 to
25afec7
Compare
yuvipanda
approved these changes
Jul 13, 2022
|
Thanks @yuvipanda ✨ I've also deployed this manually and everything seems to work as expected, so I plan to merge this soon. Quick note though https://neurohackademy.2i2c.cloud/zoom/ renders the web content, but https://neurohackademy.2i2c.cloud/zoom doesn't (similar on staging). I've opened #1517 about this. Is this an issue with the nginx config or is is something that was expected? |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info about this hub at #1505 and #1300