Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up Authentication docs into individual providers #1586

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Aug 2, 2022

I find it difficult to follow docs when they become too long on the page, especially when they are tackling multiple topics, and I've begun to struggle with our Authentication docs. Therefore, this PR splits out each auth provider into their own file, making the rendered webpages shorter and easier to parse.

@sgibson91 sgibson91 self-assigned this Aug 2, 2022
@sgibson91 sgibson91 requested a review from a team August 2, 2022 12:09
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! 🚀

@sgibson91
Copy link
Member Author

Thanks @GeorgianaElena! Do you want to merge #1583 first? I suspect a conflict will arise once one of these two is merged

@GeorgianaElena
Copy link
Member

I just merged that! Sorry for the conflict-related work that I've generated 😬

@sgibson91
Copy link
Member Author

It's ok, no worries!

@sgibson91 sgibson91 merged commit f35d06d into 2i2c-org:master Aug 2, 2022
@sgibson91 sgibson91 deleted the split-auth-docs branch August 2, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants