-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take into account all possible states of c.Authenticator.admin_users … #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list in a hub config
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
sgibson91
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4323084475 |
consideRatio
added a commit
to consideRatio/pilot-hubs
that referenced
this pull request
Sep 10, 2023
consideRatio
added a commit
to consideRatio/pilot-hubs
that referenced
this pull request
Sep 13, 2023
14 tasks
consideRatio
added a commit
to consideRatio/pilot-hubs
that referenced
this pull request
Sep 15, 2023
consideRatio
added a commit
to consideRatio/pilot-hubs
that referenced
this pull request
Sep 30, 2023
consideRatio
added a commit
to consideRatio/pilot-hubs
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…list in a hub config
Fixes #1671 based on @sgibson91 's awesome detective work ✨
With this, we can remove redundant config that specifies
"admin_users = []"
in the config, but won't do it in this PR yet, because it might cause conflicts for #2277Will do all necersary simplification of the auth config in that big PR instead.
This came up when playing with CILogon on the staging hubs, when I realized that the
2i2c dask-staging
hub had no admin users.