-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nasa-cryo: k8s 1.22 to 1.25, node sharing setup #2374
nasa-cryo: k8s 1.22 to 1.25, node sharing setup #2374
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
# </strong> | ||
# <br/> | ||
# Running servers may be forcefully stopped and service disruption | ||
# is expected. | ||
GitHubOAuthenticator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to leave this commented in? I'd suggest adding an example to the docs maybe under SRE Guilde>Support Tasks or How-to to set maintenance announcements rather than leaving commented out code lying around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 1ea720f.
Makes sense to document this, I'm opening an issue about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #2379!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4468260014 |
Thank you for helping out with reviews Pris, and thank you for the quick followup feedback!!! |
This was a planned maintenance, and the associated freshdesk ticket where it was planned is in https://2i2c.freshdesk.com/a/tickets/543.
They now have node sharing, and I also prepared for "large" 64CPU/512GB nodes to be available as that can be useful for workshops etc, which is something I think that may happen quite soon.