-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deployer: add the option to pass the debug flag to helm when deploying hubs #2416
deployer: add the option to pass the debug flag to helm when deploying hubs #2416
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. If it's not too work I've a suggestion for another flag that maps to --dry-run --debug
or just allows --dry-run
to also be set per
Yep, this is a very good idea. I will do that. I also realized that I also missed updating the deployer readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and should be fine to iterate on later without trouble if we decide to change something in this implementation.
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4502103383 |
Ref: #2205 (comment) and #1917
Wished I had this when debugging #2349 😅