Grafana dashboards for all clusters, and QCL grafana's github auth fixed #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
changed the title
The function get_grafana_url reads ingress.hosts[0] specifically, which is a broken assumption. We should fix this by looking at root_url instead in another PR.
consideRatio
force-pushed
the
pr/grafana-fixes
branch
from
7c1cb37 to
8b76f47
Compare
GeorgianaElena
approved these changes
May 9, 2023
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4991717245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have github auth setup for QCL, or automation to update the dashboards for QCL or a few other hubs. In this PR I fix this.
The grafana dashboards wasn't updated for:
Already deployed
The grafana servers have already been updated with the dashboards manually by me, and I've deployed the QCL chart config fixes already. Things seem to work out!
Related
get_grafana_urllook atroot_urlconfig #2533allowed_organizationsis case sensitive, but shouldn't be grafana/grafana#66876