Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the prototype UI for the imagebuilding-demo hub #3032

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Aug 25, 2023

Closes #2884

The prototype UI shows, although it takes a bit of time to load:
Screen Recording 2023-08-25 at 14 33 38

Important Note

There is one caveat:
I built the static assets with webpack locally then pushed them to GitHub so I can have them available. I didn't manage to do this very easily on the hub. It's at https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui/compare/main...GeorgianaElena:prototype-kubespawner-dynamic-building-ui:add-static-assets?expand=1.

@yuvipanda, what do you think? What would be the correct way to do this?

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws openscapes No Yes Following helm chart values files were modified: staging.values.yaml, common.values.yaml
aws nasa-ghg No Yes Following helm chart values files were modified: staging.values.yaml, common.values.yaml
aws nasa-veda No Yes Following helm chart values files were modified: staging.values.yaml
gcp 2i2c No Yes Following prod hubs require redeploy: imagebuilding-demo

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws openscapes prod Following helm chart values files were modified: common.values.yaml
aws nasa-ghg prod Following helm chart values files were modified: common.values.yaml
gcp 2i2c imagebuilding-demo Following helm chart values files were modified: imagebuilding-demo.values.yaml

@yuvipanda
Copy link
Member

@GeorgianaElena I think building them locally right now is ok. If you make a PR with locally built js am happy to merge that.

@GeorgianaElena
Copy link
Member Author

@GeorgianaElena GeorgianaElena merged commit ce46955 into 2i2c-org:master Aug 28, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5998204250

@GeorgianaElena GeorgianaElena deleted the enable-prototype-ui branch August 28, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Update the imagebuilding-demo hub use a hub-experimental image with the prototype kubespawner UI
2 participants