Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test if updated kubespawner resolves culler failure #3149

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] Test if updated kubespawner resolves culler failure #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f62423
Add new hub image that pins to head of kubespawner
sgibson91 Sep 15, 2023
96f2a27
[ucmerced] Use experimental image for hub
sgibson91 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/clusters/2i2c/ucmerced.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ jupyterhub:
name: quay.io/2i2c/2i2c-hubs-image
tag: "14107b8a85fb"
hub:
image:
name: quay.io/2i2c/culler-failure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be setting the image under hub.image rather than singleuser.image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #3150 about having a separate staging hub for ucmerced perhaps, given they're still on the old user image and there may be other things we need to test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woof, is it too late in the game to change that image name? I was definitely lead to believe I was changing the right thing since it was the "hubs-image"

Copy link
Contributor

@consideRatio consideRatio Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That name has confused me also, but since we are phasing it out I think we shouldn't work on changing the name at this point.

I wonder if we have this failure-to-cull result associated with using that singleuser image and/or configuring a specific jupyter server application. It could be that the user servers incorrectly reports they are active when they arent, and that is fixed by a modern jupyter server, but we are stuck with old versions in this hub because we use this old image?

tag: "0.0.1-0.dev.git.7009.h8f624235"
config:
Authenticator:
admin_users:
Expand Down
6 changes: 6 additions & 0 deletions helm-charts/chartpress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,9 @@ charts:
REQUIREMENTS_FILE: "dynamic-image-building-requirements.txt"
contextPath: "images/hub"
dockerfilePath: "images/hub/Dockerfile"
culler-failure:
imageName: quay.io/2i2c/culler-failure
buildArgs:
REQUIREMENTS_FILE: "culler-failure-requirements.txt"
contextPath: "images/hub"
dockerfilePath: "images/hub/Dockerfile"
3 changes: 3 additions & 0 deletions helm-charts/images/hub/culler-failure-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
git+https://github.com/yuvipanda/jupyterhub-configurator@ed7e3a0df1e3d625d10903ef7d7fd9c2fbb548db
# Brings in the head of kubespawner repo c.f. 2023-09-15 13:51 UTC
git+https://github.com/jupyterhub/kubespawner@9663b7e0f0d3942962c99a39c375358f19e0718e