Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UBC EOAS resource requests based on observed usage #3173

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

yuvipanda
Copy link
Member

Ref https://2i2c.freshdesk.com/a/tickets/955 for measurement and reasoning

@yuvipanda yuvipanda requested a review from a team as a code owner September 27, 2023 02:52
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws ubc-eoas No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws ubc-eoas prod Following helm chart values files were modified: common.values.yaml

memory:
# Based on measurements of observed usage
guarantee: 1G
limit: 1G
Copy link
Member

@lheagy lheagy Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we increase the limit a touch for both courses? There are a few notebooks that they will use later in the term that might exceed 1G (just barely, but they will: specifically, for 350 it is the notebook https://github.com/geoscixyz/gpgLabs/blob/main/notebooks/dcip/DC_SurveyDataInversion.ipynb). For EOSC 350, 2G would be plenty and we shouldn't exceed that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lheagy based on comments from Henryk, these are now set to 4G as they requested that.

Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adjusting to two comments, this LGTM!

eksctl/ubc-eoas.jsonnet Show resolved Hide resolved
@yuvipanda yuvipanda merged commit d7c2f7a into 2i2c-org:master Sep 28, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6333922509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants