-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ucmerced staging hub with profileList for Python and R images #3218
Add ucmerced staging hub with profileList for Python and R images #3218
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having a ucmerced-common.values.yaml
file to reduce repetition, e.g., homepage config?
Co-authored-by: Erik Sundell <[email protected]>
b15d3b4
to
21e3c46
Compare
Thanks @consideRatio and @sgibson91 for the review. I've updated the PR based on the feedback. Also, I've manually deployed this and is runnitng at https://staging.ucmerced.2i2c.cloud/ What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the adding a staging hub as a way to help the many users of ucmerced test the experience of choosing one of these images while migrating away from the one we have maintained.
Can we add a note in cluster.yaml next to this staging hub that this is to be considered an exception, and that once they want the same experience in the prod hub, we remove this staging hub?
@GeorgianaElena what was the motivation for only using profile lists on staging? I actually don't see this mentioned in the original issue |
@sgibson91 as a strategy to help them move away from using the old 2i2c maintained image, this relates to #2674 and #2583 |
Right, I just didn't think that was why the original issue was opened. I think it was opened because I tanked prod while trying to debug something right before a class 😅 |
Sorry for not linking the main issue @sgibson91 (#3188) I have now also added a comment in |
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6408123254 |
Oops I understood this initially as a "let this hub be deployed first to catch issues via our automation", but its more like a production hub that is deployed side by side with the real production ucmerced hub - used as a staging hub for the end users. I think long term if we do this again, it could be good to call this "trial hub" or similar to avoid that kind of confusion. That would then also have implied that its a short term hub. |
I'm surprised it didn't launch as a staging job given this logic infrastructure/deployer/helm_upgrade_decision.py Lines 315 to 322 in e9a7ac7
Edited to add: Actually, I think what the workflow file can't (yet) handle is multiple staging hubs on a given cluster. We make an explicit exception for "staging" and "dask-staging" on the 2i2c cluster. |
Fixes #3150
Related