Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up for a HHMI deploy re: #3332 #3333

Merged
merged 1 commit into from
Oct 27, 2023
Merged

set up for a HHMI deploy re: #3332 #3333

merged 1 commit into from
Oct 27, 2023

Conversation

jmunroe
Copy link
Contributor

@jmunroe jmunroe commented Oct 26, 2023

No description provided.

@jmunroe jmunroe requested a review from a team as a code owner October 26, 2023 17:52
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp hhmi No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp hhmi prod Following helm chart values files were modified: common.values.yaml

@jmunroe
Copy link
Contributor Author

jmunroe commented Oct 26, 2023

This will go through additional iterations after the meeting tomorrow afternoon with HHMI.

I've already tested and deployed. To keep the changes persistent, I feel I should self-merge this. Is that the correct policy? (I think so -- but I don't want to overstep)

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmunroe, we have the self-merging policy defined at https://infrastructure.2i2c.org/contributing/code-review/#self-merging-as-a-2i2c-engineer.

I suggest documenting this particular case there also if you believe qualifies.

Also, this PR looks good to me 🚀

@consideRatio
Copy link
Contributor

Nice @jmunroe!!!

Is this closing #3332 btw? Then you can add a fixes #3332 or closes #3332 in the PR description to have it close that issue. If you put it there instead of in the title, there will be a clickable link as well btw.

@jmunroe
Copy link
Contributor Author

jmunroe commented Oct 27, 2023

@jmunroe, we have the self-merging policy defined at https://infrastructure.2i2c.org/contributing/code-review/#self-merging-as-a-2i2c-engineer.

I suggest documenting this particular case there also if you believe qualifies.

Also, this PR looks good to me 🚀

Thanks @GeorgianaElena . I think the changes in this PR go beyond the guidelines for a self-merge so I will leave as they are.

@jmunroe
Copy link
Contributor Author

jmunroe commented Oct 27, 2023

Nice @jmunroe!!!

Is this closing #3332 btw? Then you can add a fixes #3332 or closes #3332 in the PR description to have it close that issue. If you put it there instead of in the title, there will be a clickable link as well btw.

Aha! I knew there was something like that but didn't know that the keywords were "fixes" and "closes". Thanks!

@jmunroe jmunroe merged commit 221992f into master Oct 27, 2023
7 checks passed
@jmunroe jmunroe deleted the hhmi_setup branch October 27, 2023 12:55
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6667481385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants