-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up for a HHMI deploy re: #3332 #3333
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
This will go through additional iterations after the meeting tomorrow afternoon with HHMI. I've already tested and deployed. To keep the changes persistent, I feel I should self-merge this. Is that the correct policy? (I think so -- but I don't want to overstep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmunroe, we have the self-merging policy defined at https://infrastructure.2i2c.org/contributing/code-review/#self-merging-as-a-2i2c-engineer.
I suggest documenting this particular case there also if you believe qualifies.
Also, this PR looks good to me 🚀
Thanks @GeorgianaElena . I think the changes in this PR go beyond the guidelines for a self-merge so I will leave as they are. |
Aha! I knew there was something like that but didn't know that the keywords were "fixes" and "closes". Thanks! |
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6667481385 |
No description provided.