Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform, gcp: enable specification of individual node pools version #3373

Merged
merged 1 commit into from
Nov 6, 2023
Merged

terraform, gcp: enable specification of individual node pools version #3373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/gcp/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ resource "google_container_node_pool" "notebook" {
cluster = google_container_cluster.cluster.name
project = google_container_cluster.cluster.project
location = google_container_cluster.cluster.location
version = var.k8s_versions.notebook_nodes_version
version = try(each.value.node_version, var.k8s_versions.notebook_nodes_version)

# terraform treats null same as unset, so we only set the node_locations
# here if it is explicitly overriden. If not, it will just inherit whatever
Expand Down
3 changes: 2 additions & 1 deletion terraform/gcp/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ variable "notebook_nodes" {
{}
),
resource_labels : optional(map(string), {}),
zones : optional(list(string), [])
zones : optional(list(string), []),
node_version : optional(string, ""),
}))
description = "Notebook node pools to create"
default = {}
Expand Down