Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using dedicated nodepool for climatematch #3380

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Stop using dedicated nodepool for climatematch #3380

merged 2 commits into from
Nov 6, 2023

Conversation

yuvipanda
Copy link
Member

Ref #3342

@yuvipanda yuvipanda requested a review from a team as a code owner November 6, 2023 09:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp 2i2c No Yes Following prod hubs require redeploy: climatematch

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp 2i2c climatematch Following helm chart values files were modified: climatematch.values.yaml

consideRatio
consideRatio reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure the node pool should be deleted as well. Should it be tracked separately? I mostly want to make sure its not forgotten, for example by a fixme note to cleanup the node pool in yhe terraform file

@yuvipanda
Copy link
Member Author

@consideRatio updated.

@consideRatio
Copy link
Contributor

@yuvipanda I'll go for a merge here to fix the pending merge conflict with another PR

@consideRatio consideRatio merged commit 881921c into 2i2c-org:master Nov 6, 2023
7 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6769710752

@consideRatio consideRatio mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @consideRatio