-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the configurator is disabled when appropriate #3641
Make sure the configurator is disabled when appropriate #3641
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very +1 on not trying to spend too much time trying to hack together something in an upstream schema for a 2i2c-specific feature. So long as an error is thrown at some point before deployment, this feels good enough to me.
Co-authored-by: Sarah Gibson <[email protected]>
Co-authored-by: Sarah Gibson <[email protected]>
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7708492552 |
Fixes #3635
Unfortunately I couldn't implement @yuvipanda's suggestion above because we do not do any validation for the jupyterhub config and we rely on it's own schema. So instead I wrote this function which is also how we validate some of the authentication configuration.
Does this make sense or should I continue to try and fiddle around with the actual schema?