-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup config connector historically used to provision gcp buckets #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is redundant since z2jh now provides egressAllowRules separate from the `egress` list of additional rules, so we don't end up overwriting anything by changing it. The `egressAllowRules` include DNS and non-private IPs for port 80 and 443 communication to other places.
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
consideRatio
changed the title
2i2c, dask-staging and ohw: transition to terraform provided buckets
Cleanup legacy bucket infrastructure and transition remaining scratch buckets
Mar 6, 2024
sgibson91
approved these changes
Mar 6, 2024
consideRatio
changed the title
Cleanup legacy bucket infrastructure and transition remaining scratch buckets
Cleanup config connector historically used to provision gcp buckets
Mar 6, 2024
Thank you @sgibson91 for reviewing!! I made another commit updating outdated docs, I figure its at least an incremental improvement - so I'll go for a merge. I'll address review feedback if done retroactively! |
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8170616150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudResources
#1046The pangeo-hubs part was partially done already via #1160, but leaving it activated so it looked like this in
pangeo-hubs
cluster:Changes
cloudResources
References
cloudResources
#1046