Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[victor] Upgrade k8s version, separate nodepools per hub, enable cost-allocation #5022

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Nov 1, 2024

Ref #4878

Copy link

github-actions bot commented Nov 1, 2024

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws victor Yes Following helm chart values files were modified: support.values.yaml Yes Following helm chart values files were modified: staging.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws victor prod Following helm chart values files were modified: prod.values.yaml

@GeorgianaElena GeorgianaElena changed the title [victor] Enable cost-allocation [victor] Upgrade k8s version, separate nodepools per hub, enable cost-allocation Nov 1, 2024
@GeorgianaElena GeorgianaElena marked this pull request as ready for review November 1, 2024 11:07
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @GeorgianaElena!

It isn't obvious if 2i2c ought to split apart node pools and home directory storage infra to become hub specific. I made a call with some discussion in #4928 that we should not do so without explicit opt-in.

The documentation you followed was written before the decision was made about this, so its written uncertain about this and hasn't been updated to reflect something about it yet.

I figure its not a problem for victor to have a split node pool for staging/prod, but for the clusters going onwards I figure we should go with the minimalistic act of using shared node pools and shared EFS storage unless they already have a separation there.

@GeorgianaElena GeorgianaElena merged commit 4d89929 into 2i2c-org:main Nov 1, 2024
9 checks passed
@GeorgianaElena GeorgianaElena deleted the victor-cost branch November 1, 2024 11:38
Copy link

github-actions bot commented Nov 1, 2024

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/11628774804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants