Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (some) excessive inline comment links #5258

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove (some) excessive inline comment links #5258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions terraform/aws/efs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// the nodes. We create a mount target for each EFS, in each subnet, even if we
// primarily put all our nodes in one - this allows for GPU nodes to be spread
// out across AZ when needed
# ref: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnets
data "aws_subnets" "cluster_node_subnets" {

filter {
Expand All @@ -23,7 +22,6 @@ data "aws_subnets" "cluster_node_subnets" {
}
}

# ref: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/security_group
data "aws_security_group" "cluster_nodes_shared_security_group" {

filter {
Expand All @@ -44,7 +42,6 @@ data "aws_security_group" "cluster_nodes_shared_security_group" {
# This allows supporting running multiple EFS instances in a cluster
# for an accurate cost allocation per hub of home directory storage.
# https://github.com/2i2c-org/infrastructure/issues/4453
# ref: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/efs_file_system
resource "aws_efs_file_system" "hub_homedirs" {
for_each = var.filestores
tags = merge(each.value.tags, {
Expand Down Expand Up @@ -102,7 +99,6 @@ locals {
]
}

# ref: https://registry.terraform.io/providers/-/aws/latest/docs/resources/efs_mount_target
resource "aws_efs_mount_target" "hub_homedirs" {
for_each = tomap({
for mount_target in local.efs_mount_targets : "${mount_target.subnet_id}.${mount_target.name}" => mount_target
Expand All @@ -119,7 +115,6 @@ output "nfs_server_dns_map" {

# Enable automatic backups for user homedirectories
# Documented in https://docs.aws.amazon.com/efs/latest/ug/awsbackup.html#automatic-backups
# ref: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/efs_backup_policy
resource "aws_efs_backup_policy" "hub_homedirs" {
for_each = aws_efs_file_system.hub_homedirs
file_system_id = each.value.id
Expand Down
Loading