Refactoring deployer exec root-homes command #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures the pod spec has the right metadata to be placed in the correct namespace - Dumps the pod spec to a temp json file - Runs kubectl create then kubectl exec to access the pod - This ensures that our bash process is NOT PID 1, which will mean the container will NOT restart if we exit that process for any reason - Cleans up the temp json file
for more information, see https://pre-commit.ci
This comment was marked as off-topic.
This comment was marked as off-topic.
…ode greater than 0, and clean up tempfile use
for more information, see https://pre-commit.ci
sgibson91
added
the
deployer:skip-deploy
…m/sgibson91/infrastructure into deployer/exec-root-homes-refactor
yuvipanda
reviewed
Dec 13, 2024
Co-authored-by: Yuvi Panda <[email protected]>
yuvipanda
reviewed
Dec 13, 2024
GeorgianaElena
approved these changes
Dec 17, 2024
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/12370550714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl runcommand into acreateandexeccouplet. This means that the bash process we start will not be PID 1, therefore we can safely exit the pod without causing it to restart (which was happening before). This is because PID 1 is special, and killing it is the same as sending a shutdown command which was causing the pod to restart.--persistoption to NOT cleanup the pod on completion if required