-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to z2jh 4 #5292
Draft
GeorgianaElena
wants to merge
11
commits into
2i2c-org:main
Choose a base branch
from
GeorgianaElena:z2jh-4-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade to z2jh 4 #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
GeorgianaElena
force-pushed
the
z2jh-4-upgrade
branch
from
December 18, 2024 14:16
6289837
to
0fdaedb
Compare
GeorgianaElena
commented
Dec 18, 2024
I tested this on staging and it worked. Then I tried testing it with profile options and GitHubOAuthenticator and ran into some issues. |
GeorgianaElena
force-pushed
the
z2jh-4-upgrade
branch
from
December 19, 2024 10:05
0fdaedb
to
dbeb246
Compare
GeorgianaElena
force-pushed
the
z2jh-4-upgrade
branch
from
December 19, 2024 13:30
5e6e3fc
to
52b2d7c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5209