Move carbonplan hub to eksctl #558
Conversation
- Use jsonnet to generate the eksctl config YAML file. This reduces duplication a lot, and matches what we do with kops. We can easily set defaults, generate nodegroup names, and set cloud tags equivalent to our node labels / taints automatically. - Install the cluster autoscaler as part of the support charts, since eksctl doesn't build that by default. It is turned off by default. - No changes were needed for the hub configuration, which is great! Inspired by 2i2c-org#436
Co-authored-by: Erik Sundell <[email protected]>
|
I struck out the TODO items. Let's get this merged first, and then we can work on the subtasks. Currently you need to have this PR cherry-picked to be able to deploy to carbonplan at all |
|
Is this waiting on anything? I see an approve from @consideRatio but I don't feel comfortable merging a PR when I don't understand what it does / what to do if something goes wrong |
|
Same here, i just approved based on my understanding - +1 for self-merge! |
|
Yeah, we should figure out policies in 2i2c-org/team-compass#175. I always feel uncomfortable self-merging, but with infrastructure as code that's often what needs to happen. I'll do that here for now. |
|
Belated review (because of holidays 😉 ). This looks nice to me except for the fact you put the autoscaler under the support chart. |
This reduces duplication a lot, and matches what we
do with kops. We can easily set defaults, generate
nodegroup names, and set cloud tags equivalent to our
node labels / taints automatically.
charts, since eksctl doesn't build that by default.
It is turned off by default.
is great!
Inspired by #436
TODO:- [ ] eksctl nodegroups are immutable, so modifying them requires manually creating a new one and removing the old one. Figure out a plan for this- [ ] Document how to create an eksctl cluster- [ ] Add guidelines on when to use eksctl vs kops