Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add readthedocs preview links to PRs #780

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sgibson91
Copy link
Member

This PR adds a GitHub Actions workflow that will automatically add a readthedocs preview link to a PR description, making it more accessible to see how documentation will look when built. An example PR is here: sgibson91/test-multilingual-sphinx#4

@sgibson91 sgibson91 requested review from choldgraf and a team November 14, 2023 10:02
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but there is some permission related issue. I'm not sure what its about, but I'll go for a pre-emptive approval assuming the fix doesn't change much or anything in the code to review here

@sgibson91
Copy link
Member Author

Debugging discussion happening in 2i2c-org/docs#194

@sgibson91
Copy link
Member Author

Solution found in: 2i2c-org/docs#194 (comment)

@sgibson91 sgibson91 merged commit 4aa6705 into 2i2c-org:main Nov 28, 2023
1 check passed
@sgibson91 sgibson91 deleted the autolink-rtd-previews branch November 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants