Skip to content

Commit

Permalink
Revert type annotations since the necessary flags are not available i…
Browse files Browse the repository at this point in the history
…n older cython versions.

This reverts commit 7e4176d.
  • Loading branch information
unhyperbolic committed Nov 19, 2024
1 parent 7e4176d commit df1c224
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 17 deletions.
4 changes: 1 addition & 3 deletions cython/core/manifold.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -607,11 +607,9 @@ cdef class Manifold(Triangulation):
return Manifold_from_Triangulation(cover, recompute=False,
manifold_class=self.__class__)

# Allow Sage integers to be accepted.
@annotation_typing(False)
def covers(
self,
degree : int,
degree,
method : typing.Optional[str] = None,
cover_type : str = 'all'
) -> 'list[snappy.Manifold]':
Expand Down
18 changes: 4 additions & 14 deletions cython/core/triangulation.pyx
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from .cache import SnapPyCache
import low_index

from cython import annotation_typing

_low_index_version = [int(n) for n in low_index.version().split('.')]

cdef class Triangulation():
Expand Down Expand Up @@ -1433,9 +1431,7 @@ cdef class Triangulation():
v += 1
return ans

# Allow Sage integers to be accepted.
@annotation_typing(False)
def gluing_equations_pgl(self, N : int = 2, equation_type : str = 'all'):
def gluing_equations_pgl(self, N =2, equation_type='all'):

"""
Returns a NeumannZagierTypeEquations object that contains a matrix
Expand Down Expand Up @@ -1836,9 +1832,7 @@ cdef class Triangulation():

return ptolemyManifoldMethods.get_ptolemy_obstruction_classes(self)

# Allow Sage integers to be accepted.
@annotation_typing(False)
def ptolemy_generalized_obstruction_classes(self, N : int):
def ptolemy_generalized_obstruction_classes(self, N):

"""
Returns the obstruction classes needed to compute
Expand Down Expand Up @@ -1903,9 +1897,7 @@ cdef class Triangulation():
ptolemyManifoldMethods.get_generalized_ptolemy_obstruction_classes(
self, N))

# Allow Sage integers to be accepted.
@annotation_typing(False)
def ptolemy_variety(self, N : int, obstruction_class = None,
def ptolemy_variety(self, N, obstruction_class = None,
simplify = True, eliminate_fixed_ptolemys = False):

"""
Expand Down Expand Up @@ -2476,11 +2468,9 @@ cdef class Triangulation():
self.num_cusps())
return cover

# Allow Sage integers to be accepted.
@annotation_typing(False)
def covers(
self,
degree : int,
degree,
method : typing.Optional[str] = None,
cover_type : str ='all'
) -> 'list[snappy.Triangulation]':
Expand Down

0 comments on commit df1c224

Please sign in to comment.