-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
KhaiTTNguyen
wants to merge
97
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Button added to index.html with behaviour defined in akeemsAdditions.js issues loading folder so ill try yo format from here
added README.md file need to add persona images
added all three personas
added link to feature list
updated ReadMe Technologies, collaborators, and project overview
no longer need persona image file
Create README.md
index.html updated to call home.js on load showing homepage content routeFw.js added for routing functionality dropdownFw.js added for dropdown menu commonStyle.css and dropdownStyle.css added
register.js added account.css added index.html modified for inventory dropdown menu and routing for register page
login.js added logout.js added index.html modified for login/logout dropdown menu
Dl Homepage and register frontend
DatabaseOperations.java access a database that is hosted on amazons web servers and has 3 functions that related to the user table. createConnect: must be called first to establish connect to the database. addUser: A boolean function that returns true if the new user was added or false if user id existed signIn: A boolean that compares entered details, if the credentials match an entry in the user table, return true else return false. closeConnection closes the connection to the database
updated to make addUser a boolean
signIn made more efficient, it now retrieves a specific entry and returns true if user_id and pass word match and false if either is wrong. By default, sql is case insensitive, Akeem == aKEEM. keep in mind for add and sign in it no longer searched whole table.
sneakerInventory.js added makeClickSort.js added to make click sortable table clickSort.css added for styling ajax.js added for ajax call inventory.json added for test of inventory page pics and icon added to make table pretty
Tp spring boot login endpoint
Dl account
… not working due to error connecting to backend (cookie/session issue)
# Conflicts: # .idea/workspace.xml # web/index.html # web/js/components/loginForm.js # web/js/components/sneakerInventoryLive.js
… not working due to error connecting to backend (cookie/session issue)
As requested, will be added to readME
Tp session revision
Testing part of Frontend webpage write up
added testing web service
Update README.md
Dl frontend demo
changed check for name since using cookie
Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
main
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @tuc56947 @Terence21 @McCoderFace3000