Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 97 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 97 commits into from

Conversation

KhaiTTNguyen
Copy link
Contributor

@KhaiTTNguyen KhaiTTNguyen commented Oct 27, 2020

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.

In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.

Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.

For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @tuc56947 @Terence21 @McCoderFace3000

KhaiTTNguyen and others added 30 commits October 27, 2020 09:39
Button added to index.html with behaviour defined in akeemsAdditions.js issues loading folder so ill try yo format from here
added README.md file
need to add persona images
added all three personas
added link to feature list
updated ReadMe Technologies, collaborators, and project overview
no longer need persona image file
index.html updated to call home.js on load showing homepage content
routeFw.js added for routing functionality
dropdownFw.js added for dropdown menu
commonStyle.css and dropdownStyle.css added
1. created new sneaker class to handle sneaker components
2. created new stockXreader class with working implementation to start from search page and retrieve price of snekaer step by step
3. created driver class for testing
4. added chromeDriver exectuable to run file
register.js added
account.css added
index.html modified for inventory dropdown menu and routing for register page
login.js added
logout.js added
index.html modified for login/logout dropdown menu
DatabaseOperations.java access a database that is hosted on amazons web servers and has 3 functions that related to the user table.

createConnect: must be called first to establish connect to the database.

addUser: A boolean function that returns true if the new user was added or false if user id existed

signIn: A boolean that compares entered details, if the credentials match an entry in the user table, return true else  return false.

closeConnection closes the connection to the database
updated to make addUser a boolean
signIn made more efficient, it now retrieves a specific entry and returns true if user_id and pass word match and false if either is wrong. By default, sql is case insensitive,
 Akeem == aKEEM. keep in mind for add and sign in

it no longer searched whole table.
sneakerInventory.js added
makeClickSort.js added to make click sortable table
clickSort.css added for styling
ajax.js added for ajax call
inventory.json added for test of inventory page
pics and icon added to make table pretty
Terence21 and others added 30 commits November 28, 2020 18:35
… not working due to error connecting to backend (cookie/session issue)
# Conflicts:
#	.idea/workspace.xml
#	web/index.html
#	web/js/components/loginForm.js
#	web/js/components/sneakerInventoryLive.js
… not working due to error connecting to backend (cookie/session issue)
As requested, will be added to readME
Testing part of Frontend webpage write up
added testing web service
changed check for name since using cookie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants