Update buttons pressed/released before calling update

Instead of up to 1000s of times a second.
32blit · Jan 2, 2021 · abc05c6 · abc05c6
1 parent 8bf872f
commit abc05c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/32blit/engine/engine.cpp b/32blit/engine/engine.cpp
@@ -77,10 +77,15 @@ namespace blit {
     // catch up on updates if any pending
     pending_update_time += (time - last_tick_time);
     while (pending_update_time >= update_rate_ms) {
+      // button state changes
+      uint32_t changed = api.buttons.state ^ api.buttons.last_state;
+
+      api.buttons.pressed = changed & api.buttons.state;
+      api.buttons.released = changed & api.buttons.last_state;
+      api.buttons.last_state = api.buttons.state;
+
       update(time - pending_update_time); // create fake timestamp that would have been accurate for the update event
       pending_update_time -= update_rate_ms;
-
-      api.buttons.pressed = api.buttons.released = 0;
     }
 
     last_tick_time = time;

diff --git a/32blit/engine/input.hpp b/32blit/engine/input.hpp
@@ -21,11 +21,6 @@ namespace blit {
 
   struct ButtonState {
     ButtonState &operator=(uint32_t v) {
-      uint32_t changed = state ^ v;
-
-      pressed |= changed & v;
-      released |= changed & state;
-
       state = v;
 
       return *this;
@@ -37,6 +32,7 @@ namespace blit {
 
     uint32_t state;
     uint32_t pressed, released; // state change since last update
+    uint32_t last_state = 0;
   };
 
   extern bool pressed(uint32_t button);