-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI to GitHub Actions #414
Conversation
The upload action can only do one file...
This note might be relevant to us, too - dask/community#107 (comment)
|
Had a bit of this done already to experiment with the warnings stuff. (Need to do something about VS, currently spamming conversion warnings)
At least GitHub credits are per-month instead of a one-time trial allocation.
The Emscripten build actually does a good job of detecting issues that would hit macOS, as it also uses clang/libc++. I had everything in one job to avoid duplicating steps (as there doesn't seem to be a nice way to reuse common steps), can probably split some stuff out... macOS would be easy as it currently doesn't do releases and the .sln build has very little in common with the other builds. |
I think the only time we might want to re-run a single step is when something in that step has a temporary (network, probably) failure. That hasn't been super common, to be fair! |
At least it's small...
Nearly there... Emscripten might need some caching (currently building libraries every time), might split that out as it has a few extra steps. VS builds are significantly faster now that we don't have to install Python (or update VS). |
Could modify the CMake bit to parse something else instead...
I think this should do everything the Travis build did and I've tested that releases still work (It does generate a few extra files now as there are always both .zip and .tar.gz). Three are a few other changes like both VS builds now use VS 2019 and all the Ubuntu-based builds are on 20.04. Hmm, ended up with quite a few commits, maybe I should squash this a bit? |
A few more commits wont hurt us, I guess! Don't worry about it. GitHub is being weird and the names of status checks in the branch protection settings don't match the checks here- I guess that'll fix itself! |
Mostly because the Travis "free" tier seems to be a trial now... and also it seems to be getting slower
Currently missing: