add dependency check script #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good start for both a |
|
What is sox for? I did not find any calls to the program. I don't have sox installed on windows and manim seems running fine. |
|
My attempt at obtaining a working virtual machine running macos has not been successful. I will not be implementing the macos portion of the script. |
|
@Kolloom the |
|
@eulertour seems sox is only used when |
|
@Kolloom yeah it's only optional, it's left over from a long time ago. |
Fix windows path black format add windows sox detection add latex package check stub for darwin some formatting sox windows detection fix add code paths for different distros fix error logic add more diagnosis messages fix python module detection add debian variant diagnosis mesg add other distro names add macos path add log read when latex fail logic fix add more mesg add missing sox diagonosis for windwos add another scipy module test add mesg for demo scene when command fails fix msg
Kolloom
changed the title
|
patch ready for review |
|
Can you open a new fork, a couple issues with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wondering if this is a reasonable approach to check manim dependencies.