Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribution #3962

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Attribution #3962

merged 4 commits into from
Nov 20, 2023

Conversation

nboisteault
Copy link
Member

No description provided.

@nboisteault nboisteault requested a review from rldhont November 13, 2023 14:36
@nboisteault nboisteault added this to the 3.7.0 milestone Nov 13, 2023
@nboisteault nboisteault added the run end2end If the PR must run end2end tests or not label Nov 13, 2023
@github-actions github-actions bot added the tests unit tests and docker configuration for tests label Nov 13, 2023
@rldhont
Copy link
Collaborator

rldhont commented Nov 13, 2023

@nboisteault you need to update this line https://github.com/3liz/lizmap-web-client/blob/master/tests/js-units/node/config/baselayer.test.js#L86

@nboisteault
Copy link
Member Author

@rldhont ready to merge?

@rldhont rldhont added run end2end If the PR must run end2end tests or not and removed run end2end If the PR must run end2end tests or not labels Nov 20, 2023
@nboisteault nboisteault merged commit 91839cf into 3liz:master Nov 20, 2023
@nboisteault nboisteault deleted the attribution branch November 20, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont approved these changes

Assignees
No one assigned
Labels
run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nboisteault @rldhont