Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IGN geoplateforme geocode completion service #3991

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Nov 30, 2023

Use the IGN geoplaforme geocoding autocompletion tool

https://geoservices.ign.fr/documentation/services/services-geoplateforme/autocompletion

Ticket : #3591

Funded by 3liz

@nboisteault
Copy link
Member

At top of file : import {transformExtent} from 'ol/proj.js';

To get map extent in 4326 : let mapExtent4326 = transformExtent(lizMap.mainLizmap.map.getView().calculateExtent(), lizMap.mainLizmap.projection, 'EPSG:4326');

@nworr nworr force-pushed the ign-geoplateform-search branch from e93087e to ec853b5 Compare December 1, 2023 13:15
@nworr nworr marked this pull request as ready for review December 1, 2023 13:16
@nworr nworr requested a review from nboisteault December 1, 2023 13:17
Copy link
Member

@nboisteault nboisteault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nworr nworr added the run end2end If the PR must run end2end tests or not label Dec 4, 2023
@nworr nworr merged commit 571328b into 3liz:master Dec 12, 2023
10 checks passed
@3liz-bot
Copy link
Contributor

The backport to release_3_6 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply ec853b50c... use IGN geoplateforme geocode completion service
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

stdout
Auto-merging assets/src/legacy/search.js
CONFLICT (content): Merge conflict in assets/src/legacy/search.js

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_6 release_3_6
# Navigate to the new working tree
cd .worktrees/backport-release_3_6
# Create a new branch
git switch --create backport-3991-to-release_3_6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ec853b50ccda789736e25ed95d94b8a8423ee2b0
# Push it to GitHub
git push --set-upstream origin backport-3991-to-release_3_6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_6

Then, create a pull request where the base branch is release_3_6 and the compare/head branch is backport-3991-to-release_3_6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 failed backport run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants