-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[end2end] cors and projet filename test converted from cypress to playwright #4009
Conversation
i created a dedicated en2end config to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as I don't review JS too much :)
But for the tests side, thanks.
i set you as reviewer for the worflow side :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nworr !
Thanks, no worries, it's what I did ! |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_6 release_3_6
# Navigate to the new working tree
cd .worktrees/backport-release_3_6
# Create a new branch
git switch --create backport-4009-to-release_3_6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 33df158c3376c14cce91cc6975e8248bc45d01a1,c4ef100540d0f52d9ee2edee2ca220bef4488611
# Push it to GitHub
git push --set-upstream origin backport-4009-to-release_3_6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_6 Then, create a pull request where the |
Tests converted using https://ray.run/tools/cypress-to-playwright and improved a bit
Funded by 3Liz