method to check if projet is compatible with target version #4078
Conversation
nworr
added
backport master
There was a problem hiding this comment.
I totally understand the PR, it works these days because we have followed this rule until now.
With one release per year, this was giving 2 years of time for a "sleeping project" to be displayed.
- 3.4 : 2020
- 3.5 : 2021
- 3.6 : 2022
- 3.7 : 2023
The variable lizmapWebClientTargetVersion in the conf file was somehow edited at the time of the release of X.Y.0 more or less to let the user enough time with these projects and the variable lizmapWebClientTargetVersion could be adjusted accordingly.
With the planned new release schedule with 2 releases per year, this is considerably reducing the timeframe (see internal issues/232#note_67164). Increasing the release schedule.
With this PR, it will be now hardcoded N+2. If we still go this way, I would rephrase the maybe as well in the conf file. Or I would even remove the configuration file and the function getLizmapWebClientTargetVersion because this would be only using the current LWC version +2 or -2 (depending of the context)
| @@ -2313,6 +2313,19 @@ public function needsUpdateWarning() | |||
| return false; | |||
| } | |||
|
|
|||
| /** | |||
| * test if provided version (int format 30520). | |||
There was a problem hiding this comment.
I guess this docstring needs to be rephrased ?
| */ | ||
| public function isCompatibleWithVersion(int $targetVersion): bool | ||
| { | ||
| // the projet version written for N are supported until N+2 |
There was a problem hiding this comment.
| // the projet version written for N are supported until N+2 | |
| // the project version written for version N are supported until version N+2 |
The minimum version allowed is determined when we are ready to release the X.Y.0 version, according to the timeframe, to let enough time for users to upgrade their project, see discussion PR #4078
Projet written for a version N are supported until N+2 version
the method can be usefull for testing projets before upgrade
Funded by 3liz