Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print legend on off #4184

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Feb 9, 2024

Bugfix JS Print : Add Legend On/Off

The print request builder was not added the LEGEND_ON and LEGEND_OFF parameters.
By using layer wmsParameters, the GetPrint request can contain legend On/Off, filter and selection.

Funded by Conseil Départemental du Gard

Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🍪

@Gustry Gustry added the sponsored development This development has been funded label Feb 9, 2024
@mdouchin mdouchin added the run end2end If the PR must run end2end tests or not label Feb 9, 2024
@rldhont rldhont force-pushed the fix-print-legend-on-off branch from 0f305c2 to 4403548 Compare February 9, 2024 14:17
The print request builder was not added the `LEGEND_ON` and `LEGEND_OFF` parameters.
By using layer wmsParameters, the GetPrint request can contain legend On/Off, filter and selection.

Funded by Conseil Départemental du Gard
@rldhont rldhont force-pushed the fix-print-legend-on-off branch from 4403548 to b2d0afa Compare February 9, 2024 14:30
@nboisteault nboisteault force-pushed the fix-print-legend-on-off branch 2 times, most recently from 7d8c9ba to 4abcd8a Compare February 12, 2024 09:56
@nboisteault
Copy link
Member

@rldhont GetPrint with symbols is not working every time at least with test stack.

simplescreenrecorder-2024-02-12_11.03.35.mp4

@nboisteault nboisteault force-pushed the fix-print-legend-on-off branch from 4abcd8a to d204c77 Compare February 12, 2024 11:29
@rldhont rldhont marked this pull request as ready for review February 12, 2024 14:52
@rldhont
Copy link
Collaborator Author

rldhont commented Feb 12, 2024

Thanks @nboisteault for the e2e tests.

If LEGEND_ON and LEGEND_OFF does not work every time with the test stack, it is probably something in QGIS Server and/org the lizmap server plugin.

This PR can be merged for me.

@nboisteault nboisteault merged commit 944e64d into 3liz:master Feb 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
printing run end2end If the PR must run end2end tests or not sponsored development This development has been funded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants